Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Artifact Assetのトリガーのマクロ化 #1621

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

💥 Artifact Assetのトリガーのマクロ化 #1621

wants to merge 24 commits into from

Conversation

haiiro2gou
Copy link
Member

@haiiro2gou haiiro2gou commented Nov 4, 2024 •
edited
Loading

仕様

  • api:artifact/** の処理の改善
  • サブトリガーの実装
    • CD発生やMP消費が行われない処理を走らせるためのトリガー
  • 装備時のステータス変動処理の内部化
  • トリガー処理のマクロ化
    • check_condition をなんとかする
    • equip 処理におけるホットバー装備の重複数を拾う
    • 装備更新を何とかする

Fixes #512
Fixes #696
Fixes #800
Fixes #1026
Fixes #1513
Fixes ProjectTSB/Asset#114

Related #1440

Rework #1485, #1489

@haiiro2gou
Copy link
Member Author

装備時の処理が鬼門だったので
全部マクロにしてやることにした

@haiiro2gou haiiro2gou changed the title 💥 Artifact Assetのリワーク 💥 Artifact Assetのトリガーをマクロによって実行できるように Nov 4, 2024
@haiiro2gou haiiro2gou changed the title 💥 Artifact Assetのトリガーをマクロによって実行できるように 💥 Artifact Assetのトリガーのマクロ化 Nov 4, 2024
@haiiro2gou haiiro2gou marked this pull request as ready for review November 17, 2024 14:51
@haiiro2gou
Copy link
Member Author

それぞれのTriggerに条件を登録できるようにすれば
こんな過剰量のトリガーファイルを生み出さなくてよくなるのかもしれない…

@haiiro2gou haiiro2gou mentioned this pull request Nov 22, 2024
Open
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch 2 times, most recently from 0e125fb to b438503 Compare November 23, 2024 08:29
@haiiro2gou
🧑‍💻 神器の生成処理を再構築する
a9c0b84
@haiiro2gou
🧑‍💻 落下耐性Attributeを正負反転して処理するように
10ac5c8
@haiiro2gou
🔥 トリガー処理を一旦削除
c0b8660
@haiiro2gou
🚚 ArtifactEvents.Killed -> ArtifactEvents.Kill
5ea14cd
@haiiro2gou
🚚 LocalCoolDown -> LocalCooldown
02d4c5a
@haiiro2gou
🚚 NewとOldをasset:contextから外す
0f0498e
@haiiro2gou
🧑‍💻 Slot <-> Indexの変換処理を実装
395ca63
@haiiro2gou
🧑‍💻 トリガー処理を再実装
74799f8
@haiiro2gou
🧑‍💻 トリガーの呼び出し処理を実装
bbcea6f
@haiiro2gou
♻️ 使用条件を確認する処理をリファクタリング
232e35a
@haiiro2gou
♻️ 神器を使用する処理をリファクタリング
6a24299
@haiiro2gou
🧑‍💻 攻撃時のトリガー処理を実装
06c9fc2
@haiiro2gou
🧑‍💻 被ダメージ時のトリガー処理を実装
b63cd36
@haiiro2gou
🧑‍💻 敵撃破時のトリガー処理を実装
06e2c16
@haiiro2gou
🧑‍💻 スニーク時のトリガー処理を実装
a1dc7dc
@haiiro2gou
🧑‍💻 回復時のトリガー処理を実装
94813a1
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch 2 times, most recently from 0d04384 to d331ae1 Compare November 23, 2024 14:51
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch 2 times, most recently from 59c6716 to 03dc669 Compare November 23, 2024 18:30
@haiiro2gou
Copy link
Member Author

ToDo: Slot変数を拾い上げる

@haiiro2gou haiiro2gou mentioned this pull request Nov 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenCMD ChenCMD Awaiting requested review from ChenCMD ChenCMD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@haiiro2gou